Re: [2.6 patch] mark pci_find_device() as __deprecated

From: Arjan van de Ven
Date: Sun Nov 19 2006 - 09:15:10 EST


On Sun, 2006-11-19 at 15:04 +0100, Adrian Bunk wrote:
> On Sun, Nov 19, 2006 at 10:47:12AM +0100, Arjan van de Ven wrote:
> >
> > >
> > > Oh, and if anything starts complaining "But this adds some warnings to
> > > my kernel build!", he should either first fix the 200 kB (sic) of
> > > warnings I'm getting in 2.6.19-rc5-mm2 starting at MODPOST or go to hell.
> >
> > we can solve this btw; we could have a
> >
> > #define THIS_MODULE_IS_LEGACY_CRAP_AND_WONT_GET_FIXED
> >...
>
> The few warnings by __deprecated are not that much of a problem.

yes they are; the current situation prevents things that are used in
only a set of old unmaintained legacy drivers (read: ISDN) as being
marked __deprecated because they add too many warnings, while the API
really should be marked deprecated..

think for example the entire sleep_on() family of API's (which basically
are impossible to use race-free in 2.6)





--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/