Re: [PATCH] PCMCIA identification strings for cards manufacturedby Elan

[Arjan van de Ven]

Hi,

> a card is inserted, resulting in various random lockups
> 
> *** linux-2.6.18/sound/pcmcia/pdaudiocf/pdaudiocf.c.orig	2006-11-20 10:24:23.000000000 +0000
> --- linux-2.6.18/sound/pcmcia/pdaudiocf/pdaudiocf.c	2006-11-20 10:33:46.000000000 +0000
> ***************
> *** 298,306 ****
>   /*
>    * Module entry points
>    */
>   static struct pcmcia_device_id snd_pdacf_ids[] = {
> ! 	PCMCIA_DEVICE_MANF_CARD(0x015d, 0x4c45),


please use the "-u" option for diff; that's the preferred (only) form
the Linux kernel folks are used to looking at diffs, and applying them.
Also, it's very helpful and customary to also pass the "-p" option (this
improves the context so that reviews are easier)

would you mind redoing the diff and then resending it?

Thanks!


-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/