Re: [PATCH 46/61] fix Intel RNG detection

[Michael Buesch]

On Tuesday 21 November 2006 00:45, Dave Jones wrote:
> On Tue, Oct 31, 2006 at 09:34:26PM -0800, Chris Wright wrote:
>  
>  > From: Jan Beulich <jbeulich@xxxxxxxxxx>
>  > 
>  > [PATCH] fix Intel RNG detection
>  > 
>  > Previously, since determination whether there was an Intel random number
>  > generator was based on a single bit, on systems with a matching bridge
>  > device but without a firmware hub, there was a 50% chance that the code
>  > would incorrectly decide that the system had an RNG.  This patch adds
>  > detection of the firmware hub to better qualify the existence of an RNG.
>  > 
>  > There is one issue with the patch: I was unable to determine the LPC
>  > equivalent for the PCI bridge 8086:2430 (since the old code didn't care
>  > about which of the many devices provided by the ICH/ESB it was chose to use
>  > the PCI bridge device, but the FWH settings live in the LPC device, so the
>  > device list needed to be changed).
>  > 
>  > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
>  > Signed-off-by: Michael Buesch <mb@xxxxxxxxx>
>  > Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
>  > Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx>
>  > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
>  > Signed-off-by: Chris Wright <chrisw@xxxxxxxxxxxx>
> 
> 
> Since I pushed an update to our Fedora users based on 2.6.18.2, a few people
> have reported they no longer have their RNG's detected.
> Here's one report: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215144

Well, this patch should acutally fix false detections.
Did these people actually have a _working_ rng before?
I saw a report of a mac user, for which the rng disappeared. But
the previously "detected" rng didn't work either. (Work as in produces
sane random numbers). So there actually wasn't a rng available all the time.

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/