Re: [PATCH 2.6.19-rc6] sata_promise updates

From: Jeff Garzik
Date: Tue Nov 21 2006 - 16:10:09 EST


Jeff Garzik wrote:
1) no_tbg_slew_init should be a bit flag ("1 << 0") inside a 'flags' variable in struct pdc_host_priv.


Thinking some more, a 'is_gen_II' bit flag inside a 'flags' struct member would more accurately describe what the boolean flag indicates.

Once NCQ support is added, we will probably have to test this flag in code unrelated to TBG/slew registers.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/