Re: [PATCH 2.6.19-rc6] ata_piix: IDE mode SATA patch for Intel ICH9

[Tejun Heo]

Gaston, Jason D wrote:
> Did this come through ok, using Evolution, or do I need to try a
> different email client and send again?

It's wrapped and more comments below.

> -----Original Message-----
> From: Gaston, Jason D 
> Sent: Tuesday, November 21, 2006 2:52 PM
> To: jgarzik@xxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; Gaston, Jason D
> Subject: [PATCH 2.6.19-rc6] ata_piix: IDE mode SATA patch for Intel ICH9
>
> This patch adds the Intel ICH9 IDE mode SATA controller DID's.
>
> Signed-off-by:  Jason Gaston <jason.d.gaston@xxxxxxxxx>
>
> --- linux-2.6.19-rc6/drivers/ata/ata_piix.c.orig	2006-11-20
> 04:58:48.000000000 -0800
> +++ linux-2.6.19-rc6/drivers/ata/ata_piix.c	2006-11-20
> 06:15:12.000000000 -0800

Above two lines are wrapped.

> @@ -127,6 +127,7 @@
>  	ich6_sata_ahci		= 8,
>  	ich6m_sata_ahci		= 9,
>  	ich8_sata_ahci		= 10,
> +	ich9_sata_ahci		= 11,

AFAICS, ich9 isn't different from ich8.  Any reason not to simply use 
ich8_sata_ahci?

[--snip--]
> +static const struct piix_map_db ich9_map_db = {
> +	.mask = 0x3,
> +	.port_enable = 0x3,
> +	.present_shift = 8,

I guess this patch is against libata-dev#upstream-fixes.  Just FYI 
.present_shift is gone in libata-dev#upstream.

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/