Re: [Linux-fbdev-devel] fbmem: is bootup logo broken for monochromeLCD ?

From: James Simmons
Date: Wed Nov 22 2006 - 16:05:28 EST



> James Simmons wrote:
> > Lets look at the new code that I have done with your above parameters.
> >
> > for (i = image->height; i--; ) {
> > shift = val = 0;
> > n = image->width;
> > dst = (u32 __iomem *) dst1;
> >
> > while (n--) {
> > if (!s) { src++; s = 32; }
> > s -= 1;
> > color = (swapb32p(src) & (1 << s)) ? 1 : 0;

Replace the below line in my patch I sent

> > val |= color << shift;

with
val <<= shift;
val |= color;

> > /* Did the bitshift spill bits to the next long? */
> > if (shift >= 31) {
> > FB_WRITEL(val, dst++);
> > val = (shift == 31) ? 0 :(color >> (32 - shift));
> > }
> > shift += 1;
> > shift &= (32 - 1);
> > }
> >
> > [ ...]

Let me know if that works.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/