Re: [PATCH] fix random SD/MMC card recognition failures on ARM Versatile

From: Russell King
Date: Thu Nov 23 2006 - 11:04:02 EST


On Thu, Nov 23, 2006 at 06:46:06PM +0300, Vitaly Wool wrote:
> Hello Pierre,
>
> currently sometimes the SD/MMC card inserted results in recognition failure on ARM Versatile board:
>
> <<<Plug in MMC card>>>
>
> root@versatile:~# mmcblk0: mmc0:0001 SDMB-32 31360KiB
> mmcblk0:<3>mmcblk0: error 3 transferring data
> end_request: I/O error, dev mmcblk0, sector 0
> Buffer I/O error on device mmcblk0, logical block 0
> mmcblk0: error 3 transferring data
> end_request: I/O error, dev mmcblk0, sector 0
> Buffer I/O error on device mmcblk0, logical block 0
> unable to read partition table
>
> This patch fixes the problem.

Doubtful. mmci_stop_data() already does this, which will be called
immediately prior to mmci_request_end(). So you're doubling up the
writes to registers again.

Since this is not the first occurance that you've had to do this with
your board (the other being the SIC) I suggest that your board is
faulty in some way, causing writes to registers to be occasionally
dropped.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/