Re: [PATCH 3/5] PCI : Add selected_regions funcs

From: Alan
Date: Thu Nov 23 2006 - 16:37:37 EST


On Thu, 23 Nov 2006 20:33:32 +0100
Ingo Oeser <ioe-lkml@xxxxxxxxxx> wrote:

> Hi Hidetoshi Seto,
>
> bitfields (and bitmask) should be unsigned and use machine word size,
> which is usually "long". So please pass them in "unsigned long" instead of "int".

There are a fixed number of BARs , besides which the interface already
uses int for the mask in pci_enable_device_bars() so the use of int is
fine and continues the existing API.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/