Re: [RFC] timers, pointers to functions and type safety

From: Al Viro
Date: Sat Dec 02 2006 - 17:00:08 EST


On Sat, Dec 02, 2006 at 10:43:58PM +0100, Roman Zippel wrote:

> You need some more magic macros to access/modify the data field.

Which is done bloody rarely. grep and you'll see... BTW, there are
other reasons why passing struct timer_list * is wrong:
* direct calls of the timer callback
* callback being the same for two timers embedded into
different structs
* see a timer callback, decide it looks better as a tasklet.
What, need a different glue now?

Look, it's a delayed call. The less glue we need, the better - the
rules are much simpler that way, so that alone means that we'll get
fewer fsckups.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/