Re: [PATCH 22/35] Unionfs: Lookup helper functions

From: Jan Engelhardt
Date: Tue Dec 05 2006 - 16:37:34 EST



>+/* allocate new dentry private data, free old one if necessary */
>+int new_dentry_private_data(struct dentry *dentry)
>+{
>[...]
>+
>+ spin_unlock(&dentry->d_lock);
>+ return 0;
>+ /* */
>+
>+out_free:
>+ kfree(info->lower_paths);
>+
>+out:
>+ free_dentry_private_data(info);
>+ dentry->d_fsdata = NULL;
>+ spin_unlock(&dentry->d_lock);
>+ return -ENOMEM;
>+}

Whereever I go, ... care to explain the /* */? If it was just a marker
logically belonging to the syntactic sugar, it's missing in the other source
files too.


-`J'
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/