Re: [patch] net: dev_watchdog() locking fix

[Herbert Xu]

On Thu, Dec 07, 2006 at 09:55:22PM +0100, Ingo Molnar wrote:
> 
> fallout of the recent big networking merge i guess. Tested fix below. 
> David, Herbert, do you agree with it, or is it a false positive?

I agree that this is a bug, but the fix is in the wrong spot.  The
dev_watchdog function already runs in softirq context so it doesn't
need to disable BH.

You can almost be guaranteed that if netpoll is involved in a bug
then it should be fixed :)

In this case, it's taking the tx lock in process context which is
not allowed.  So it should disable BH before taking the tx lock.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/