Re: [GIT PATCH] HID patches for 2.6.19

From: Greg KH
Date: Fri Dec 08 2006 - 16:13:29 EST


On Fri, Dec 08, 2006 at 11:28:57AM -0800, Linus Torvalds wrote:
>
>
> On Fri, 8 Dec 2006, Greg KH wrote:
> >
> > Here are some patches that move the HID code to a new directory allowing
> > it to be used by other kernel subsystems easier.
>
> I pulled. However, I think the Kconfig changes are HORRIBLE.
>
> I don't understand why people don't use "select" more. Why should Kconfig
> ask for "Generic HID support?" That question _never_ makes sense to a
> user. And if you answer "n", you'll not get USB_HID.
>
> This is not user-friendly. If you need HID support, just select it. Don't
> ask people questions that make no sense. If the generic HID code is needed
> for some driver, you just select it. If it's not needed, you don't. It's
> that easy.

I think some people feel we are using "select" too much at times, so
that is why it was done that way.

But in this case, yes, I do think it would make it easier for the user
if it was changed. Jiri, care to make up a new patch that does this?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/