Re: [patch 2.6.19-git] watchdog: at91_wdt build fix

From: David Brownell
Date: Sun Dec 10 2006 - 16:11:23 EST


On Sunday 10 December 2006 11:23 am, Wim Van Sebroeck wrote:
> Hi David,
>
> > Recent miscdev changes broke various drivers, so they won't build.
> > This fixes another one.
>
> See also Andrew Victor's patch (dated 04/Dec/2006) in the
> linux-2.6-watchdog tree. It's indeed the at91rm9200_wdt, the mpcore_wdt
> and the omap_wdt that are affected by the miscdev changes

I was just following the "fix brown paper bags ASAP" policy.
One that seems followed less closely than usual in the current
kernel tree. :(


> (See Driver core: change misc class_devices to be real devices
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=94fbcded4ea0dc14cbfb222a5c68372f150d1476 )

Hmm, I'm a bit surprised that not all the watchdog drivers have
this issue. Is the problem that most of them don't actually
adhere to the driver model ... that is, most don't have any kind
of (platform or other) device backing the watchdog?

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/