Re: + schedule_on_each_cpu-use-preempt_disable.patch added to -mm tree

From: Ingo Molnar
Date: Fri Dec 15 2006 - 03:35:56 EST



* akpm@xxxxxxxx <akpm@xxxxxxxx> wrote:

> - mutex_lock(&workqueue_mutex);
> + preempt_disable(); /* CPU hotplug */
> for_each_online_cpu(cpu) {
> INIT_WORK(per_cpu_ptr(works, cpu), func);
> __queue_work(per_cpu_ptr(keventd_wq->cpu_wq, cpu),
> per_cpu_ptr(works, cpu));
> }
> - mutex_unlock(&workqueue_mutex);
> + preempt_enable();

Why not cpu_hotplug_lock()?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/