Re: [PATCH/v2] CodingStyle updates

From: Pavel Machek
Date: Fri Dec 15 2006 - 09:24:06 EST


Hi!

> Pavel Machek wrote:
> >> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> >> +Use one space around (on each side of) most binary and ternary operators,
> >> +such as any of these:
> >> + = + - < > * / % | & ^ <= >= == != ? :
> >
> > Actually, this should not be hard rule. We want to allow
> >
> > j = 3*i + l<<2;
>
> Which would be very misleading. This expression evaluates to
>
> j = (((3 * i) + l) << 2);
>
> Binary + precedes <<.

Aha, okay. So this one should be written as

j = 3*i+l << 2;

(Well, parenthesses should really be used. Anyway, sometimes grouping
around operator is useful, even if I made mistake demonstrating that.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/