Re: [PATCH] support HDIO_GET_IDENTITY in libata

From: Jeff Garzik
Date: Sat Dec 16 2006 - 11:34:32 EST


Erik Andersen wrote:
On Thu Dec 14, 2006 at 03:31:30PM -0500, Jeff Garzik wrote:
Erik Andersen wrote:
+ if (!atapi_enabled && dev->class == ATA_DEV_ATAPI) {
This seems like an impossible condition?

Hmm, suppose so. Do you think that simply doing:
if (dev->class == ATA_DEV_ATAPI) {
here would be sufficient?

Yep. There is also a selection of helpers in include/linux/libata.h starting with ata_class_enabled() that might be useful.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/