Re: + down_write-preserve-local-irqs.patch added to -mm tree

From: Arjan van de Ven
Date: Wed Dec 20 2006 - 05:54:42 EST


On Wed, 2006-12-20 at 02:38 -0800, akpm@xxxxxxxx wrote:
> The patch titled
> down_write(): preserve local irqs
> has been added to the -mm tree. Its filename is
> down_write-preserve-local-irqs.patch
>
> See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
> out what to do about this
>
> ------------------------------------------------------
> Subject: down_write(): preserve local irqs

excuse me? Am I missing something here?

down_write() is a sleeping function, right? what business does it have
to be *ever* called with irqs off?

if the answer is "none whatsoever", what good is saving irq state then?



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/