Re: Fix IPMI watchdog set_param_str() using kstrdup

From: Sébastien Dugué
Date: Wed Dec 20 2006 - 06:32:28 EST


On Wed, 20 Dec 2006 13:19:09 +0200 "Pekka Enberg" <penberg@xxxxxxxxxxxxxx> wrote:

> On 12/20/06, Sébastien Dugué <sebastien.dugue@xxxxxxxx> wrote:
> > set_param_str() cannot use kstrdup() to duplicate the parameter. That's
> > fine when the driver is compiled as a module but it sure is not when
> > built into the kernel as the kernel parameters are parsed before the
> > kmalloc slabs are setup.
>
> Aah. I wonder though, if we could defer parsing driver parameters
> until kmalloc caches are up...

From a general point of view, why not. Except that for the
watchdog case, I want it to start as soon as possible for it to be
able to reboot in case of an early crash.

Sébastien.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/