[PATCH 3/3] Char: mxser_new, remove useless spinlock

From: Jiri Slaby
Date: Fri Dec 22 2006 - 17:51:34 EST


mxser_new, remove useless spinlock

gm_lock is useless, since ISA is configured at init time and there it's
serialized.

Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>

---
commit 5f93193574c932263132e3262853be671e9d1642
tree 94693e221836fd7234e290b9911757357889a580
parent 04a4dbf03a9fdc4c53282ab7e1db146389140c3b
author Jiri Slaby <jirislaby@xxxxxxxxx> Fri, 22 Dec 2006 23:04:17 +0059
committer Jiri Slaby <jirislaby@xxxxxxxxx> Fri, 22 Dec 2006 23:04:17 +0059

drivers/char/mxser_new.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/char/mxser_new.c b/drivers/char/mxser_new.c
index 2f173e9..103f0b5 100644
--- a/drivers/char/mxser_new.c
+++ b/drivers/char/mxser_new.c
@@ -313,7 +313,6 @@ static int mxvar_diagflag;
static unsigned char mxser_msr[MXSER_PORTS + 1];
static struct mxser_mon_ext mon_data_ext;
static int mxser_set_baud_method[MXSER_PORTS + 1];
-static spinlock_t gm_lock;

#ifdef CONFIG_PCI
static int __devinit CheckIsMoxaMust(int io)
@@ -1377,7 +1376,6 @@ static int __init mxser_program_mode(int port)
{
int id, i, j, n;

- spin_lock(&gm_lock);
outb(0, port);
outb(0, port);
outb(0, port);
@@ -1385,7 +1383,6 @@ static int __init mxser_program_mode(int port)
(void)inb(port);
outb(0, port);
(void)inb(port);
- spin_unlock(&gm_lock);

id = inb(port + 1) & 0x1F;
if ((id != C168_ASIC_ID) &&
@@ -2684,7 +2681,6 @@ static int __init mxser_module_init(void)
mxvar_sdriver = alloc_tty_driver(MXSER_PORTS + 1);
if (!mxvar_sdriver)
return -ENOMEM;
- spin_lock_init(&gm_lock);

printk(KERN_INFO "MOXA Smartio/Industio family driver version %s\n",
MXSER_VERSION);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/