Re: Want comments regarding patch

From: Arjan van de Ven
Date: Thu Dec 28 2006 - 13:58:01 EST

On Thu, 2006-12-28 at 19:41 +0100, Daniel MarjamÃki wrote:
> Hello all!
> I sent a patch with this content:
> - for (i = 0; i < MAX_PIRQS; i++)
> - pirq_entries[i] = -1;
> + memset(pirq_entries, -1, sizeof(pirq_entries));
> I'd like to know if you have any comments to this change. It was of
> course my intention to make the code shorter, simpler and faster.


personally I don't like the new code; memset only takes a byte as
argument and while it probably is the same, that is now implicit
behavior and no longer explicit. A reasonably good compiler will notice
it's the same and generate the best code anyway, so I would really
really suggest to go for the best readable code, which imo is the
original code.

Arjan van de Ven

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at