Re: [PATCH 4/8] KVM: Implement a few system configuration msrs

[Avi Kivity]

Ingo Oeser wrote:
> Hi,
>
> On Thursday, 28. December 2006 11:11, Avi Kivity wrote:
>   
> > Index: linux-2.6/drivers/kvm/svm.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/kvm/svm.c
> > +++ linux-2.6/drivers/kvm/svm.c
> > @@ -1068,6 +1068,9 @@ static int emulate_on_interception(struc
> >  static int svm_get_msr(struct kvm_vcpu *vcpu, unsigned ecx, u64 *data)
> >  {
> >  	switch (ecx) {
> > +	case 0xc0010010: /* SYSCFG */
> > +	case 0xc0010015: /* HWCR */
> > +	case MSR_IA32_PLATFORM_ID:
> >  	case MSR_IA32_P5_MC_ADDR:
> >  	case MSR_IA32_P5_MC_TYPE:
> >  	case MSR_IA32_MC0_CTL:
> >     
>
> What about just defining constants for these?
> Then you can rip out these comments.
>
> Same for linux-2.6/drivers/kvm/vmx.c
>   

Yes, there are a few more of these as well.  I'll clean them up once 
things quiet down a bit.

--
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/