Re: [PATCH] slab: cache alloc cleanups

[Christoph Lameter]

On Tue, 2 Jan 2007, Pekka J Enberg wrote:

> +
> +	if (nodeid == -1 || nodeid == numa_node_id()) {
> +		if (unlikely(current->flags & (PF_SPREAD_SLAB | PF_MEMPOLICY))) {
> +			obj = alternate_node_alloc(cache, flags);
> +			if (obj)
> +				goto out;
> +		}

This reintroduces a bug that was fixed a while ago.

kmalloc_node() must never obey memory policies. 
Alternate_node_alloc implements memory policies.

With this patch kmalloc_node(...., numa_node_id()) would get redirected 
again to other nodes if a memory policy is in effect.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/