Re: [PATCH] qconf: fix SIGSEGV on empty menu items

From: Roman Zippel
Date: Fri Jan 05 2007 - 22:22:04 EST


Hi,

On Thu, 4 Jan 2007, Cyrill V. Gorcunov wrote:

> qconf may cause SIGSEGV by trying to show debug
> information on empty menu items

Thanks, but this is more complex than necessary.
It simply lacks some initializers.

bye, Roman

Signed-off-by: Roman Zippel <zippel@xxxxxxxxxxxxxx>

---
Index: linux-2.6/scripts/kconfig/qconf.cc
===================================================================
--- linux-2.6.orig/scripts/kconfig/qconf.cc 2007-01-05 01:47:54.000000000 +0100
+++ linux-2.6/scripts/kconfig/qconf.cc 2007-01-05 01:56:54.000000000 +0100
@@ -915,7 +915,7 @@ void ConfigView::updateListAll(void)
}

ConfigInfoView::ConfigInfoView(QWidget* parent, const char *name)
- : Parent(parent, name), menu(0)
+ : Parent(parent, name), menu(0), sym(0)
{
if (name) {
configSettings->beginGroup(name);
@@ -951,6 +951,7 @@ void ConfigInfoView::setInfo(struct menu
if (menu == m)
return;
menu = m;
+ sym = NULL;
if (!menu)
clear();
else
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/