Re: [PATCH] sata_sis: Support for PATA supports

[Jeff Garzik]

Alan wrote:
> This is quick rework of the patch Uwe proposed but using Kconfig not
> ifdefs and user selection to sort out PATA support. Instead of ifdefs and
> requiring the user to select both drivers the SATA driver selects the
> PATA one.
>
> For neatness I've also moved the extern into the function that uses it.
>
> Two questions really
> 1.	Do you want the extern in a header file

not for an atom so small.

When I mentioned header files (if this was the genesis of your 
question), I intentionally referred to sata_promise.h as an example of 
sharing /code/ between two drivers.


> 2.	Is this now neat enough to keep you happy Jeff or shall I do
> the library split anyway ?

It's still ugly relying on an unused driver like this, but this 
[current] revision is clean enough that I'll go ahead and apply this patch.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/