Re: [PATCH] Clean up PPC code to use canonical alignment macros fromkernel.h.

[Robert P. J. Day]

On Tue, 9 Jan 2007, Paul Mackerras wrote:

> Robert P. J. Day writes:
>
> >   Clean up some PowerPC source files to use the canonical alignment
> > macros from kernel.h, and add an ALIGN_DOWN() macro to kernel.h for
> > symmetry.
>
> [snip]
>
> >   and, no, i didn't test-compile this as i don't have a PPC
> > cross-compiler at the moment.  sorry.
>
> Yeah.  I would be surprised if it did build, since you are removing
> definitions without adding any #includes to make sure we get the
> global definition.
>
> >  arch/powerpc/boot/addRamDisk.c               |    3 +--
> >  arch/powerpc/boot/of.c                       |    2 +-
> >  arch/powerpc/boot/page.h                     |    9 +--------
> >  arch/powerpc/boot/simple_alloc.c             |    8 ++++----
>
> NAK.  Stuff in arch/powerpc/boot intentionally *doesn't* depend on
> Linux kernel headers, since it runs outside of the kernel, either on
> the build machine (addRamDisk.c) or before the kernel.

whoops, sorry, i totally missed that.  my apologies.

rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/