Re: [PATCH 2/3] eCryptfs: Generalize metadata read/write

[Andrew Morton]

On Tue, 9 Jan 2007 16:22:55 -0600
Michael Halcrow <mhalcrow@xxxxxxxxxx> wrote:

> +		lower_file->f_op->write(lower_file, (char __user *)page_virt,
> +					PAGE_CACHE_SIZE, &lower_file->f_pos);

hm.  sys_write() takes a local copy of f_pos and writes that back into the
struct file.  It does this so that two concurrent write() callers don't
make a mess of f_pos, and of the file contents.

Perhaps ecryptfs should be calling vfs_write()?

That way we'd also get the fsnotify notifications, which ecryptfs presently
appears to have subverted.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/