Re: [discuss] [2.6 patch] x86_64: re-add a newline toRESTORE_CONTEXT

[Jan Beulich]

>>> Andrew Morton <akpm@xxxxxxxx> 09.01.07 23:04 >>>
>On Tue, 9 Jan 2007 12:01:21 +0100
>Andi Kleen <ak@xxxxxxx> wrote:
>
>> On Tuesday 09 January 2007 03:55, Adrian Bunk wrote:
>> > RESTORE_CONTEXT lost a newline in 
>> > commit 658fdbef66e5e9be79b457edc2cbbb3add840aa9:
>> > http://www.mail-archive.com/kgdb-bugreport@xxxxxxxxxxxxxxxxxxxxx/msg00559.html 
>> 
>> I don't think we should add such changes for external patchkits.
>> 
>> In general kgdb shouldn't add any patches at all. If the existing 
>> hooks are not enough they should submit their changes needed so
>> that it can just work.
>> 
>
>But the patch is a bugfix.  Without it, you cannot do
>
>	RESTORE_CONTEXT	\
>	.globl ...	\

Their use was broken in the first place - they shouldn't have made
assumptions about the contents of the macro, by writing this like

	RESTORE_CONTEXT "\n\t"	\
	".globl ..."	\

if they really need to make use of the macro. This is similar to
requirements of other (assembly) macros that normally also
don't have a line terminator and hence require the users to
add appropriate line termination after the macro name (and
eventual arguments).

I would even go as far as asking for removing the \n\t on SAVE_CONTEXT
and the left \t on RESTORE_CONTEXT.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/