Re: [PATCH 2.6.20-rc4 1/4] futex priority based wakeup

[Daniel Walker]

On Wed, 2007-01-10 at 17:29 +0100, Pierre Peiffer wrote:

> > 
> > Is this really necessary? The rtmutex will priority sort the waiters
> > when you enable priority inheritance. Inside the wake_futex_pi() it
> > actually just pulls the new owner off another plist inside the the
> > rtmutex structure.
> 
> Yes. ... necessary for non-PI-futex (ie "normal" futex)...
> 
> As the hash_bucket_list is used and common for both futex and PI-futex, yes, in 
> case of PI_futex, the task is queued two times in two plist.

You could make them distinct .. Also Did you consider merging the PI
path and the non-PI code path? then you could modify the rtmutex to
toggle PI depending .

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/