Re: PATCH - x86-64 signed-compare bug, was Re: select() setting ERESTARTNOHAND (514).

From: Andi Kleen
Date: Wed Jan 10 2007 - 20:37:35 EST


On Thursday 11 January 2007 02:02, Neil Brown wrote:
> On Thursday January 11, ak@xxxxxxx wrote:
> > > Just a 'me too' at this point.
> > > The X server on my shiny new notebook (Core 2 Duo) occasionally dies
> > > with 'select' repeatedly returning ERESTARTNOHAND. It is most
> > > annoying!
> >
> > Normally it should be only visible in strace. Did you see it without
> > strace?
>
> No, only in strace.

strace leaks internal errors. At some point that should be fixed,
but it's not really a serious problem.

There was one other report of internal errors leaking without strace,
but it was vague and I never got confirmation.

> Still, I think it would be safer to have the cast, in case the compiler
> decided to be clever.... or does the C standard ensure against that?

It does.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/