Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

[Alan]

> 		if(strstr(id->model, "Integrated Technology Express")) {
> 			/* In raid mode the ident block is slightly buggy
> 			   We need to set the bits so that the IDE layer knows
> 			   LBA28. LBA48 and DMA ar valid */
> 			id->capability |= 3;		/* LBA28, DMA */
> 
> and we are better off using generic helper if we can
> (which may later allow us to use generic tuning code).

IT8212 in smart mode has no tuning at all, the real modes are hidden by
the controller. Some firmware versions don't seem to be like being fed
set features commands either hence the total lack of tuning.

> 
> Before my patch hwif->autodma was only checked in the chipset specific
> hwif->ide_dma_check implementations.  For ide-cris it is
> cris_dma_check()
> function so there no behavior change here.

Ok
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/