Re: any value to fixing apparent bugs in old ISDN4Linux?

From: Karsten Keil
Date: Mon Jan 15 2007 - 08:57:37 EST


On Mon, Jan 15, 2007 at 06:43:30AM -0500, Robert P. J. Day wrote:
>
> $ grep -r DE_AOC .
> ./.config:CONFIG_DE_AOC=y
> ./drivers/isdn/hisax/l3dss1.c:#ifdef HISAX_DE_AOC
> ./drivers/isdn/hisax/l3dss1.c:#else /* not HISAX_DE_AOC */
> ./drivers/isdn/hisax/l3dss1.c:#endif /* not HISAX_DE_AOC */
> ./drivers/isdn/hisax/Kconfig:config DE_AOC
>
> it seems like there's a name mismatch between the config variable
> and the one that's being tested, no?
>
> OTOH, since that code *is* in the allegedly obsolete old ISDN4Linux
> code, perhaps that entire part of the tree can just be junked. but if
> it's sticking around, it should probably be fixed.
>


Yes thanks for discover this. Since the code only affect the
analyse of the AOC info which is pure information only without real
function it was not detected before.

--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/