Re: [PATCH]: MTRR: fix 32-bit ioctls on x64_32

[H. Peter Anvin]

Mikael Pettersson wrote:
> These #ifdefs are too ugly.
>
> Since you apparently just add aliases for the case labels,
> and do no actual code changes, why not
> 1. make the new cases unconditional, or 
> 2. invoke a translation function before the switch which
>    maps the MTRRCIOC32_ constants to what the kernel uses

Adding a case can add substantially to the generated code, especially if 
it makes a compact set of case labels non-compact.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/