Re: [PATCH] Centralize the macro definition of "__packed".

From: Tim Schmielau
Date: Thu Jan 18 2007 - 11:49:30 EST


On Thu, 18 Jan 2007, Robert P. J. Day wrote:

> Centralize the attribute macro definition of "__packed" so no
> subsystem has to do that explicitly.
>
> Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
>
> ---
>
> compile tested to make sure the HFS subsystem still builds. now
> there's just 50 gazillion usages of "__attribute__((packed))" that can
> be tightened up.
>
>
> fs/hfs/hfs.h | 2 --
> fs/hfsplus/hfsplus_raw.h | 2 --
> include/linux/compiler-gcc.h | 1 +
> 3 files changed, 1 insertion(+), 4 deletions(-)

Moving definitions into compiler-gcc.h only will screw non-gcc compilers
like icc.
They should probably go into the generic section of compiler.h instead.

Tim
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/