Re: [patch] hid: put usb_interface instead of usb_device into hid->dev

From: Jiri Kosina
Date: Fri Jan 19 2007 - 13:14:58 EST


On Fri, 19 Jan 2007, Anssi Hannula wrote:

> The commit 4916b3a57fc94664677d439b911b8aaf86c7ec23 introduced a
> hid regression between 2.6.19 and 2.6.20-rc1. The device put in
> input_dev->cdev is now of type usb_device instead of usb_interface.

Yes, this is apparently a bug. Thanks a lot for the patch.

> Fix this by assigning the intf->dev into hid->dev, and fixing all the
> users.
>
> Signed-off-by: Anssi Hannula <anssi.hannula@xxxxxxxxx>
>
> ---
>
> I recommend this fix to go to the stable tree before 2.6.20 is released.

Looks OK to me. I have queued it in HID tree - I am going to push this
upstream in a few days.

--
Jiri Kosina

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/