Re: [patch 3/3] clockevent driver for arm/pxa2xx

[Guennadi Liakhovetski]

On Tue, 9 Jan 2007 s.hauer@xxxxxxxxxxxxxx wrote:

> Add a clockevent driver for pxa systems. This patch also removes the pxa
> dyntick support since it is not necessary anymore with generic dynamic
> tick support
> 
> Signed-off-by: Luotao Fu <lfu@xxxxxxxxxxxxxx>
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> 
> ---
>  arch/arm/mach-pxa/time.c |  106 ++++++++++++++++++++++-------------------------
>  1 file changed, 51 insertions(+), 55 deletions(-)
> 
> Index: arch/arm/mach-pxa/time.c
> ===================================================================
> --- a/arch/arm/mach-pxa/time.c.orig
> +++ b/arch/arm/mach-pxa/time.c
> @@ -19,6 +19,7 @@
>  #include <linux/errno.h>
>  #include <linux/sched.h>
>  #include <linux/clocksource.h>
> +#include <linux/clockchips.h>
>  
>  #include <asm/system.h>
>  #include <asm/hardware.h>
> @@ -29,6 +30,50 @@
>  #include <asm/mach/time.h>
>  #include <asm/arch/pxa-regs.h>
>  
> +static u32 clockevent_mode = 0;
> +
> +static void pxa_set_next_event(unsigned long evt,
> +				  struct clock_event_device *unused)
> +{
> +	OSMR0 = OSCR + evt;
> +}

This doesn't work for me in various nasty ways. Please, check for a 
minimum delay or loop to get ahead of time. See code in the "old" timer 
ISR. See how it unconditionally adds at least 10 ticks...

Thanks
Guennadi
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/