[patch] i386: add option to show more code in oops reports

From: Chuck Ebbert
Date: Wed Jan 24 2007 - 15:22:59 EST


Sometimes we may need to see more code than the default in an oops,
so add an option for that.

Signed-off-by: Chuck Ebbert <cebbert@xxxxxxxxxx>

Documentation/kernel-parameters.txt | 5 +++++
arch/i386/kernel/traps.c | 17 +++++++++++++++--
2 files changed, 20 insertions(+), 2 deletions(-)

--- 2.6.20-rc5-32.orig/Documentation/kernel-parameters.txt
+++ 2.6.20-rc5-32/Documentation/kernel-parameters.txt
@@ -361,6 +361,11 @@ and is between 256 and 4096 characters.
clocksource is not available, it defaults to PIT.
Format: { pit | tsc | cyclone | pmtmr }

+ code_bytes [IA32] How many bytes of object code to print in an
+ oops report.
+ Range: 64 - 1024
+ Default: 64
+
disable_8254_timer
enable_8254_timer
[IA32/X86_64] Disable/Enable interrupt 0 timer routing
--- 2.6.20-rc5-32.orig/arch/i386/kernel/traps.c
+++ 2.6.20-rc5-32/arch/i386/kernel/traps.c
@@ -94,6 +94,7 @@ asmlinkage void spurious_interrupt_bug(v
asmlinkage void machine_check(void);

int kstack_depth_to_print = 24;
+int code_bytes = 64;
ATOMIC_NOTIFIER_HEAD(i386die_chain);

int register_die_notifier(struct notifier_block *nb)
@@ -324,7 +325,7 @@ void show_registers(struct pt_regs *regs
*/
if (in_kernel) {
u8 *eip;
- int code_bytes = 64;
+ int code_prologue = code_bytes * 43 / 64;
unsigned char c;

printk("\n" KERN_EMERG "Stack: ");
@@ -332,7 +333,7 @@ void show_registers(struct pt_regs *regs

printk(KERN_EMERG "Code: ");

- eip = (u8 *)regs->eip - 43;
+ eip = (u8 *)regs->eip - code_prologue;
if (eip < (u8 *)PAGE_OFFSET ||
probe_kernel_address(eip, c)) {
/* try starting at EIP */
@@ -1191,3 +1192,15 @@ static int __init kstack_setup(char *s)
return 1;
}
__setup("kstack=", kstack_setup);
+
+static int __init code_bytes_setup(char *s)
+{
+ code_bytes = simple_strtoul(s, NULL, 0);
+ if (code_bytes < 64)
+ code_bytes = 64;
+ if (code_bytes > 1024)
+ code_bytes = 1024;
+
+ return 1;
+}
+__setup("code_bytes=", code_bytes_setup);