Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git mast er

From: Sergei Shtylyov
Date: Thu Jan 25 2007 - 09:29:56 EST


Hello.

Marc St-Jean wrote:

> I could use both iotype and type with a test on each for the appropriate
> bug, what do you recommend?

I think iotype would be enough. You can't pass type for platform devices anyway, IIRC (the thing I don't quite like).

I just found that out the hard way, it get's overwritten during autoconfig* and
ends up back at PORT_16550A.

I'm now trying to use my own iotype = UPIO_DWAPB and I've added it to all cases
that check for UPIO_MEM. However at boot time I'm getting:
"serial8250: ttyS0 at *unknown* (irq = 27) is a 16550A".
It looks like something outside of 8250.c must be checking for UPIO_MEM, I'm
looking into it.

Yeah, be sure to change serial_core.c as well (whereever you'll see UPIO_AU/TSI there)... Quite ugly. :-/

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/