On Thu, Jan 25, 2007 at 03:38:24PM -0800, Pete Zaitcev wrote:On Thu, 25 Jan 2007 16:18:35 -0500, Kristian H??gsberg <krh@xxxxxxxxxx> wrote:
Fortunately we do not care about out-of-tree drivers, which are mostI see that ORBs are always allocated with a call (like SKB) and notOh, the ORBs are SBP-2 specific data structures, struct fw_transaction is probably what corresponds to USB URBs. This struct is defined in fw-transaction.h and is available for embedding into other structs, such as struct sbp2_orb in fw-sbp2. Is that what you're suggesting against, and what are the problems with this approach?
embedded into drivers (like URBs). It's great, keep it up. Also,
never allow drivers to pass DMA-mapped buffers into fw_send_request
and friends. We made both of these mistakes in USB, and it hurts.
affected, you may even call it a feature ^_^. My main problem is,
we can't refcount URBs, so usbmon can't tap them and must copy.
urbs are reference counted, it's just that not all drivers who create
them use them that way :(
Perhaps you can inforce this in the new codebase...