Re: [PATCH] AGPGART compat ioctl

[Christoph Hellwig]

On Sat, Jan 27, 2007 at 07:28:07PM -0800, Zwane Mwaikambo wrote:
> --- linux-2.6.20-rc4-mm1/include/linux/agpgart.h	27 Jan 2007 22:04:06 -0000	1.1.1.1
> +++ linux-2.6.20-rc4-mm1/include/linux/agpgart.h	27 Jan 2007 22:41:23 -0000
> @@ -114,6 +114,67 @@ typedef struct _agp_unbind {
>  
>  #define AGPGART_MINOR 175
>  
> +#ifdef CONFIG_COMPAT
> +#include <linux/compat.h>

I don't think this should be in public headers.  I'd rather have all
declarations and code for compat ioctl handling in a single file,
e.g. drivers/char/agp/compat_ioctl.c

> +#ifdef CONFIG_COMPAT
> +static int compat_agpioc_info_wrap(struct agp_file_private *priv, void __user *arg)

Please make sure this doesn't overflow 80 characters per line.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/