Re: [PATCH] mm: remove global locks from mm/highmem.c

From: Ingo Molnar
Date: Sun Jan 28 2007 - 13:21:46 EST



* Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Sun, Jan 28, 2007 at 04:48:06PM +0100, Ingo Molnar wrote:
> > i'm sorry, but do you realize that files_lock is a global lock,
> > triggered by /every single/ file close?
>
> Please check which thread you're in before you start such lengthy
> rants.

my reply applies to the other thread too, you made a similar comment
there too:

* Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Sun, Jan 28, 2007 at 12:51:18PM +0100, Peter Zijlstra wrote:
> > This patch-set breaks up the global file_list_lock which was found
> > to be a severe contention point under basically any filesystem
> > intensive workload.
>
> Benchmarks, please. Where exactly do you see contention for this?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/