Re: ARM i.MX serial: fix tx buffer overflows

[Konstantin Kletschke]

Am 2007-01-05 19:01 +0100 schrieb Pavel Pisa:

> It applies only for interrupts going through GPIO layer.
> The problem has been noticed by Konstantin Kletschke
> some time ago.
> 
>   No IRQF_TRIGGER set_type function for IRQ 26 (MPU)

Yes. I reported this also.

>  drivers/serial/imx.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: linux-2.6.19-rt/drivers/serial/imx.c
> ===================================================================
> +++ linux-2.6.19-rt/drivers/serial/imx.c
> @@ -403,7 +403,8 @@ static int imx_startup(struct uart_port 
>  	if (retval) goto error_out2;
>  
>  	retval = request_irq(sport->rtsirq, imx_rtsint,
> -			     IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
> +			     (sport->rtsirq < IMX_IRQS) ? 0 :
> +			       IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
>  			     DRIVER_NAME, sport);
>  	if (retval) goto error_out3;


Okay, this indeed fixes my

No IRQF_TRIGGER set_type function for IRQ 26 (MPU)

here!

Regards, Konsti

-- 
GPG KeyID EF62FCEF
Fingerprint: 13C9 B16B 9844 EC15 CC2E  A080 1E69 3FDA EF62 FCEF
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/