Re: [PATCH] Fix /sys/device/.../power/state regression

[Pavel Machek]

Hi!

> > Change breaking that was 'introduce suspend early to fix suspend on
> > mac mini', by Linus, IIRC. So no, it is not easy to revert this one.
> 
> But it's easy to fix it. Either drivers need suspend routines that

Yes, that's right. It is easy to fix, but not as easy as "just revert".

> called without interrupts enabled, or they don't. The current situation 
> is that the interface is broken regardless of which is the case - the 
> situation with the patch is that the interface only stops working for 
> drivers that need the suspend routine to be called with disabled 
> interrupts. 

...unfortunately that patch was pretty ugly, and it still does not
solve the "will it oops when I try to use it" part of problem.

(Thanks for your ipw2100 runtime pm work, btw).
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/