Re: [PATCH] ubi: int versus size_t printk warnings

[David Woodhouse]

On Wed, 2007-01-31 at 17:02 +0000, Alan wrote:
> Another mtd driver, another set of 32bit assumptions. Please compile mtd
> stuff on 64bit now and then, or if stuff is for 32bit only systems then
> add the right CONFIG rules.

We've been building MTD stuff on 64-bit machines since about 1999, when
I first put a DiskOnChip in an ISA eval board in an Alpha. 

The _problematic_ 32-bit assumption in MTD code is the fact that device
size is limited to 4GiB. That used to be "insanely large" in the context
of flash chips, but it's not so any more. We'll have to deal with that
soon enough.

> +               ubi_err("error %d while reading %Zd bytes from PEB %d:%d, "

Nak. %Zd is a gratuitous GNUism. In C, we use %zd.

Artem (dedekind) is the correct person to deal with UBI stuff. I've
added him to Cc.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/