Re: [PATCH RFC] sd: spin down disks on removal or power-down

[Robert Hancock]

Stefan Richter wrote:
> Robert Hancock wrote:
> > > http://marc.theaimsgroup.com/?t=116922621200002
> > It looks like Tejun's patch essentially does the same thing as mine with
> > the addition of the control from userspace. There is one exception
> > though, my patch also does the stop on removal of the SCSI disk (i.e.
> > writing 1 to its "delete" file in sysfs, what scsiadd -r does).
>
> Isn't sd_shutdown called at this occasion?

Ah, indeed it is. I was thinking of the way I had written my patch, 
where it only does the spindown if the system state is SYSTEM_POWER_OFF 
so I needed an extra call to force this on removal. Tejun's patch just 
checks for not SYSTEM_RESTART, so it should happen on removal as well.

--
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@xxxxxxxxxxxxx
Home Page: http://www.roberthancock.com/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/