Re: [PATCH] fix cc-option-yn whitespace

From: Linus Torvalds
Date: Wed Feb 07 2007 - 23:34:48 EST




On Wed, 7 Feb 2007, Roland McGrath wrote:

> This change:
>
> commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7
> Author: Oleg Verych <olecom@xxxxxxxxxxxxxx>
> Date: Tue Feb 6 02:18:21 2007 +0100
>
> [PATCH] kbuild: improve option checking, Kbuild.include cleanup
>
> introduced leading whitespace in the results of cc-option-yn and such.
> This breaks some of their uses, like HAS_MTUNE in arch/i386/Makefile.cpu.

Yes.. It doesn't seem to happen with make-3.81, for some reason, and I
don't see why the leading space happens. Maybe somebody with deep GNU make
knowledge knows.

I committed the hopefully equivalent patch (that also removes the
symlinking to /dev/null that Roman objected to).

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/