Re: dd

From: Mike Frysinger
Date: Thu Feb 08 2007 - 00:56:41 EST


On 2/8/07, Oleg Verych <olecom@xxxxxxxxxxxxxx> wrote:
> Check to see if `${CROSS_COMPILE}mkimage` exists and if not, fall back to
> the standard `mkimage`

Why this can't be done by

PATH=$CROSS_COMPILE:$PATH

in your environment?

because it wouldnt matter ? the tool is called
"$CROSS_COMPILE-mkimage", it isnt $CROSS_COMPILE_PATH/mkimage

> The Blackfin toolchain includes mkimage, but we dont want to namespace
> collide with any of the user's system setup, so we prefix it with our
> toolchain name.

If that matter, `type -path' is bashizm (BloAted SHell), and "blackbox"
with "dash" (very good `sh' equivalents) will fail. I would recomend to
use "which" command (btw, Debian has `sh' version of it), if you
concerned about size and performance.

Nack + proposition to move from `bash' to `sh'.

the script already uses "#!/bin/bash" and the patch doesnt change any
of the existing conventions ... so if you want to rewrite the existing
code to be POSIX compliant, then do so so i can add back in support
for $CROSS_COMPILE-mkimage
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/