Re: [BUG][PATCH] fix mempolcy's check on a system with memory-less-node take2

From: Andi Kleen
Date: Thu Feb 08 2007 - 02:50:33 EST



> This panic(hang) was found by a numa test-set on a system with 3 nodes, where
> node(2) was memory-less-node.

I still think it's the wrong fix -- just get rid of the memory less node.
I expect you'll likely run into more problems with that setup anyways.

> static struct mempolicy *mpol_new(int mode, nodemask_t *nodes)
> {
> struct mempolicy *policy;
> + void *val;

Using void * here is nasty when it's a zonelist pointer.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/