Re: Network: convert network devices to use struct device instead of class_device

From: Dmitry Torokhov
Date: Thu Feb 08 2007 - 12:29:34 EST


On 2/8/07, Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx> wrote:
On Thu, 08 Feb 2007 07:43:18 -0500
Jeff Garzik <jeff@xxxxxxxxxx> wrote:

> Linux Kernel Mailing List wrote:
> > Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=43cb76d91ee85f579a69d42bc8efc08bac560278
> > Commit: 43cb76d91ee85f579a69d42bc8efc08bac560278
> > Parent: 2943ecf2ed32632473c06f1975db47a7aa98c10f
> > Author: Greg Kroah-Hartman <gregkh@xxxxxxx>
> > AuthorDate: Tue Apr 9 12:14:34 2002 -0700
> > Committer: Greg Kroah-Hartman <gregkh@xxxxxxx>
> > CommitDate: Wed Feb 7 10:37:11 2007 -0800
> >
> > Network: convert network devices to use struct device instead of class_device
> >
> > This lets the network core have the ability to handle suspend/resume
> > issues, if it wants to.

It fixes a non-problem. I would like to see the network core suspend/resume
proposal as well. Last time I examined doing network core suspend help,
the problem was that the physical device suspend was called before the
class device. It is not clear how this change would help.

If physical devices are registered before class devices then when
suspending class devices are naturally suspended first. It is still
not clear to me why we need to convert everythign to struct device, I
believe I've shown (with patches) that it is possible to integrate
struct class_device into PM framework and avoid reshuffling half of
the kernel code.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/