Re: [ck] Re: Swap prefetch merge plans

[jos poortvliet]

> > > Hold.
> > Why hold?
>
> > It's been shown this patchset really helps desktop users.
>
> Has it?  I don't think I've ever observed any benefits from it and I don't
> think anyone has ever got down and worked out what its drawbacks might be,
> and seen if they can be demonstrated in practice.

Well, I'd say it's disadvantage is that you might use the buffered diskdata in 
memory (which will be replaced with application data from swap) when you come 
back using the computer. But it's far more likely you'll use the app data, 
that's why swap prefetch helps. Anyway, I'm sure you got some response from 
users who did like it. Now I know the desktop isn't the focus of the Linux 
Kernel Developers, and you probably have much to hefty hardware to notice any 
difference. Heck, after my upgrade to 3GB ram, I never noticed swap prefetch 
anymore...

But there ARE ppl using KDE or Gnome on a 256 MB ram system (or even less) and 
they would notice this. I know I do on my 192-mb-ram laptop with Kubuntu... 
It's lovely to do some compiling task, then while you work in vi swap 
prefetch ensures everything is smooth when you try to continue browsing with 
firefox...

> I also have vague memories of some serious-sounding review comments about
> the code from Nick.

Nick's comment, replying to me some time ago:

> > well, the reason i use it is my computer is much more reactive in the
> > morning. linux uses to get very slow after a night of not-doing-much
> > except some 'sleep 5h && blabla' and cron stuff. in the morning it takes
> > a few HOURS to get up and running smoothly. with swap prefetch, it
> > actually feels faster compared to a fresh boot. now you can force swap
> > prefetch to start working, i use it now and then after some heavy taskts
> > which pulled everything to swap.
>
> I have two issues with this argument (not that I'm trying to say it
> couldn't make a difference in your case).
>
> Firstly, swap prefetch actually doesn't handle the midnight updatedb
> pageout problem nicely. It doesn't do any prefetching when the
> pagecache/vfs cache fills memory (which is what would have to happen for
> updatedb to push stuff into swap).

But doesn't it prefetch stuff after updatedb has run and the computer is idle? 
Updatedb here runs at night, and swap prefetch is supposed to get my app data 
back in memory during the time after updatedb pushed it out, right? Maybe Con 
can explain here...

> Secondly, with or without swap prefetch, I think we can do a better job of
> handling these use-once patterns to begin with.
well, i'd love to see you elaborate on this. I mean, if the kernel could be 
made smarter and swap prefetch wouldn't be needed, great...

> > Why keep it in -mm for so long?
>
> I'm waiting to be shown that its benefits exceed its costs.  Sometimes
> that's hard.

Nobody has said anything about costs, indeed. Now afaik, swap prefetch is 
designed to have no/as little as possible costs, so that makes sense. Does it 
have to have some bugs, which have to be adressed, before it can enter? I'm 
sure this can be arranged, right, Con?

Sorry if I sound sarcastic. I'm no hacker myself, and sometimes these 
discussions don't make sense to me. A bit like the Staircase thingy ->

"hi, I've got this piece of code which does the same as that piece, but 
better"
"Why didn't you improve the old code?"
"This is a better design -> half the code but doing a better job"
"Well, it's not tested as much, so it won't go in. Go away!"

There where those comments from Torvalds some time ago in an interview, about 
the kernel community becoming harder to get involved with. As an outsider, it 
sure seems so. I read frustrations everywhere. What about the kevent guy, his 
blog: http://tservice.net.ru/~s0mbre/blog

I stumbled upon it when reading LWN. Seems pretty sad... I don't get the 
technical stuff, but the frustration almost blows up your monitor. Is there 
something fundamentally wrong with the kernel-hackers-culture, or are these 
incidents?

grtz

Jos

-- 
Disclaimer:

Alles wat ik doe denk en zeg is gebaseerd op het wereldbeeld wat ik nu heb. 
Ik ben niet verantwoordelijk voor wijzigingen van de wereld, of het beeld wat 
ik daarvan heb, noch voor de daaruit voortvloeiende gedragingen van mezelf. 
Alles wat ik zeg is aardig bedoeld, tenzij expliciet vermeld.

Attachment: pgp00000.pgp
Description: PGP signature