Re: NAK new drivers without proper power management?

From: Alan
Date: Sun Feb 11 2007 - 19:21:27 EST


> +PM support: Since Linux is used on many portable and desktop systems, your
> + driver is likely to be used on such a system and therefore it
> + should support basic power management by implementing, if
> + necessary, the .suspend and .resume methods used during the
> + system-wide suspend and resume transitions. You should verify
> + that your driver correctly handles the suspend and resume, but
> + if you are unable to ensure that, please at least define the
> + .suspend method returning the -ENOSYS ("Function not
> + implemented") error. Note, however, that in such a case your
> + submission is likely to be suspended and only resumed when the
> + driver correctly handles this feature.

I'd lose the last bit. Just end it at "error.", there are going to be
people who produce good reasons not to handle suspend/resume.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/